Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Create Guru3d.com.xml - #4281

Merged
J0WI merged 12 commits into
masterfrom
unknown repository
Mar 23, 2016
Merged

J0WI merged 12 commits into
masterfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Mar 6, 2016

Copy link
Copy Markdown

No description provided.

@funkydude

Copy link
Copy Markdown
Contributor

You should forward requests from guru3d.com to www.guru3d.com and add a cookie rule.

@ghost

ghost commented Mar 16, 2016

Copy link
Copy Markdown
Author

@J0WI Can you pull?

@funkydude

Copy link
Copy Markdown
Contributor

@Ekaris Please fix your rule to also forward https queries: from="^https?://guru3d\.com/"

You're still missing a cookie rule, you should start adding these for complete coverage.

Also list the following as refused:
capone.guru3d.com
downloads.guru3d.com
forums.guru3d.com

@J0WI

J0WI commented Mar 17, 2016

Copy link
Copy Markdown
Contributor

I didn't get any cookies on www.guru3d.com.
The redirect for https shouldn't be necessary here, because they are no links pointing to this url (see discussion in #4303).
However, you also have to put ^guru3d.com in the list of refused hosts.

@ghost

ghost commented Mar 17, 2016

Copy link
Copy Markdown
Author

Good?

@funkydude

Copy link
Copy Markdown
Contributor

@J0WI you are probably blocking them, I see 5 cookies, all __utm related, originating from .guru3d.com

Also you have no way of knowing what or who links to this website. There is no downside to forwarding the https domain.

@Ekaris sorry you're getting bounced around like this... Note: you've actually removed the redirect entirely.

@ghost

ghost commented Mar 21, 2016

Copy link
Copy Markdown
Author

I only get 1 cookie and it's empty, besides using securecookie on all rules is a theme for a discussion on mailing list, can you pull @J0WI ?

@funkydude

Copy link
Copy Markdown
Contributor

@Ekaris No, it isn't. Setting secure cookie on all rules would be stupid, hence why it's optional. It's to be used on a case by case basis where it doesn't break a website. In this situation the rule is so simple it can be safely used.

Also, stop demanding your PRs be merged, ask for review. They will be merged when they are ready, yours isn't. You need to fix your redirect for ^guru3d.com as I already stated.

@J0WI

J0WI commented Mar 21, 2016

Copy link
Copy Markdown
Contributor

I agree that this discussion should be somewhere else. I never required to secure cookies in the past and I won't require it here - nevertheless it would be nice to have.

But the redirect from ^ to www is a real blocker.

@funkydude

Copy link
Copy Markdown
Contributor

@J0WI Not trying to imply that a securecookie rule should be a requirement. However, as a frequent contributor, it is something he should consider adopting for complete coverage.

@funkydude

Copy link
Copy Markdown
Contributor

Only issue I see is you've accidentally got 4 w's in the cookie host. For future reference, you can just use .+ in basic rules like these. Doing so will also save memory, as a new RegEx won't be created.

The test URL shouldn't be needed I don't think ( @J0WI ?). The script should handle it.

@J0WI
J0WI merged commit cf86269 into EFForg:master Mar 23, 2016
@J0WI

J0WI commented Mar 23, 2016

Copy link
Copy Markdown
Contributor

Thanks!

@ghost
ghost deleted the patch-32 branch April 5, 2016 07:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants